- Boost - lists.boost.org

Preliminary Review Request: boost-memory
by shiwei xu 08 May '08

08 May '08

What is new? 1. Lock-free free list. 2. Provide both region allocators (boost::auto_alloc, boost::scoped_alloc) and general-purpose allocators (boost::gc_alloc<http://cpp.winxgui.com/boost-gc-alloc> ). Highlights: 1. Allocating memory is very fast. 2. No memory leaks. No need to delete objects manually. Or forgetting to delete objects is allowed. --- What is boost-memory? It provides allocators named "GC Allocator". Note "GC Allocator" isn't GC. GC Allocator is different from STL Allocator. The following is minimum specification for GC Allocator: typedef void (*DestructorType)(void* data); concept GCAllocator { // Allocate memory without given a cleanup function void* allocate(size_t cb); // Allocate memory with a cleanup function void* allocate(size_t cb, DestructorType fn); // Cleanup and deallocate all allocated memory by this GC Allocator void clear(); // Swap two GCAllocator instances void swap(GCAllocator& o); }; For more information about GC Allocator, refer to http://www.codeproject.com/KB/cpp/gc-allocator.aspx

5 18

Trac open bugs - by assignee
by Marshall Clow 08 May '08

08 May '08

[ 305 open bugs today, 302 Tuesday ] Note that these will be intermittent while I am at BoostCon..... If you are maintaining a library, and have not logged into the trac system at <http://svn.boost.org/trac/boost/>, please do so ASAP. Until you do that, no tickets can be assigned to you, and will remain under "None". Instructions on working with tickets can be found at: <http://svn.boost.org/trac/boost/wiki/TicketWorkflow> and a mapping of user names to "real names" can be found at: <http://svn.boost.org/trac/boost/report/16> Bug summary 33 djowel 26 az_sw_dude 23 dgregor 22 grafik 19 dave 18 vladimir_prus 16 bemandawes 12 ramey 12 no-maintainer 12 anthonyw 11 turkanis 11 agurtovoy 10 jsiek 9 rogeeff 8 nesotto 6 danieljames 5 igaztanaga 4 witt 4 pavol_droba 4 johnmaddock 4 ebf 3 samuel_krempp 3 kaalus 3 danielw 3 None 2 troyer 2 shammah 2 nasonov 2 marshall 2 jmaurer 2 hkaiser 2 garcia 1 urzuga 1 t_schwinger 1 speedsnail 1 matias 1 jano_gaspar 1 gmelquio 1 fcacciola 1 dlwalker 1 aaron_windsor 1 <Blank> <Blank> 1750 Autolink library name not in sync with actually build lib None 1736 Headers containing non ASCII characters cause MS VC to issue warning 4819 in some locales None 1900 Missing documentation for mpl::print in the MPL library None 1901 Missing documentation for mpl::for_each in the MPL library aaron_windsor 1622 Adjacency list needs to handle self-edges correctly agurtovoy 1001 gcc 4.1.2 segfaults on mpl/test/apply.cpp agurtovoy 1051 MPL header ordering triggers bug agurtovoy 1099 unable to iterate through a "non-explicitly-declared" mpl::set agurtovoy 1215 Boost 1.34.1_ mpl: Wrong workaround detection using MinGW32 (or.hpp_ line #33) agurtovoy 1317 has_xxx randomly broken in msvc agurtovoy 1469 [mpl] nested typedef of set has two different meanings agurtovoy 1476 always<> is not nullary. agurtovoy 1528 g++ 4.3.0 reports error because of redeclaration of next agurtovoy 1549 Boost.MPL: 'index_of' algorithm is not documented agurtovoy 1568 duplicate include guards agurtovoy 588 mpl::remove compile error with gcc 4.1.0 anthonyw 1154 tss destruction segfaults in conjunction with dlopen/dlclose anthonyw 1168 [thread] tss crashes randomly anthonyw 1268 xtime_cmp changes to deal with overflow were reverted anthonyw 1470 Boost.Thread: Compilation errors with non-__cdecl calling convention anthonyw 1805 thread creation crashes with /Zp1 switch in VS2005 compiler anthonyw 1813 Signed/Unsigned warning in win32/condition_variable anthonyw 1825 thread.hpp injects windows.h and breaks user application. anthonyw 1826 Auto detection of threadapi and target-os broken under cygwin gcc anthonyw 1867 Missing member functions in shared_mutex (win32) anthonyw 1905 shared_mutex::timed_lock can leave mutex thinking there's a waiting writer anthonyw 876 xtime documentation incomplete anthonyw 881 errors when build with Apache stdcxx az_sw_dude 1028 typo in boost header: date_time/time_defs.hpp az_sw_dude 1078 from_iso_string cannot read the output from to_iso_string az_sw_dude 1098 Urgent libboost-date-time1.33.1 : bugs on ia64 ? az_sw_dude 1147 date_time library contains global #define ERROR az_sw_dude 1160 warning: month_format shadows a member of this az_sw_dude 1162 warning: ticks shadows a member of this az_sw_dude 1289 posix_time::time_facet forgets to pass a_ref argument to base class az_sw_dude 1299 change in typedef stringstream_type in format_date_parser.hpp causing compilation error az_sw_dude 1306 invalid docbook in date_period.xml az_sw_dude 1384 Linking problem with date_time library on Visual C++ 2008 Express az_sw_dude 1524 format_date_parser.hpp(221) : cannot convert parameter 1 az_sw_dude 1574 operator<< for boost::posix_time::ptime ignores ostream flags az_sw_dude 1674 date_time::date_formatting.hpp: incorrectly formats year using global locale az_sw_dude 1695 add correct namespace to class to fix compilation bug az_sw_dude 1726 boost/date_time/posix_time/time_formatters.hpp incorrectly formats fractional seconds using global locale az_sw_dude 1740 date_time includes <windows.h> az_sw_dude 1788 local_time::local_time_period streaming operators not implemented az_sw_dude 1859 boost::gregorian::to_tm() doesn't fill in tm_zone on Mac OS X az_sw_dude 1878 Documention Corrections - Various date_time Pages az_sw_dude 1903 [date_time] - 1.34+ c_local_adjustor derefs null pointer for dates >2038 az_sw_dude 287 wrong usage of ios_base::narrow az_sw_dude 316 date_time type conversion warning az_sw_dude 604 from_ftime incorrectly processes FILETIME filled with zeros az_sw_dude 642 operator<< for gregorian::date_duration not found az_sw_dude 889 Insane Dependencies az_sw_dude 890 date_time library supports only the current dst rule bemandawes 1378 filesystem path invalid name for hidden files (LINUX) bemandawes 1389 filesystem::ostream << boost::format generates operator ambigious error (in MSVC++) bemandawes 1458 Darwin Tiger throws std::runtime_error: locale::facet::_S_create_c_locale name not valid bemandawes 1578 bug in readdir_r_simulator() in a multi-threaded environment bemandawes 1583 Serious flaw in boost::filesystem filename handling (opensuse) bemandawes 1589 [filesystem] 'mbstate_t' : is not a member of 'std' bemandawes 1606 filesystem/src/exception.cpp doesn't build with gcc bemandawes 1613 Link Errors against file_system on OS X with Intel Version 10.1 C++ compilers bemandawes 1682 path_traits needs imbue() bemandawes 1701 boost::filesystem::remove_all - segmentation fault with wpath on Linux bemandawes 1711 Boost Serialization export facility broken on gcc 4.1_ 4.2 bemandawes 1767 missing file: boost/filesystem/cerrno.hpp bemandawes 1768 system: error_code.cpp #defines macros without checking whether already defined bemandawes 1840 name check functions have different behavior wrt empty string bemandawes 1876 portable_file_name() returns true for '.' and '..' bemandawes 752 directory_iterator doesn't work with catch danieljames 1554 When BOOST_HASH_NO_EXTENSIONS is defined hash doesn't support new string types. danieljames 1555 When BOOST_HASH_NO_EXTENSIONS is defined hash doesn't support boost::system::error_code danieljames 1705 [boostbook] Spaces in reference file names for types like 'long long' danieljames 1742 Some bugs in http://www.boost.org/doc/libs/1_35_0 danieljames 1743 Documentation has incorrect Build & Link settings for some libraries danieljames 1818 The tables in status reports jump all over the place. danielw 1044 Argument pack inaccessable in a functions return type danielw 1054 Parameter takes an "infinite" amount of time to compile with the Intel compiler. danielw 1097 keyword.hpp generates many warnings C4180: qualifier applied to function type has no meaning; ignored dave 1010 linking boost.python on freebsd dave 1019 iterator_facade::pointer should be the return type of operator-> (DR 445) dave 1085 Python rules for compiling in Mac OS X dave 1179 [boost.python] can not export a union in VC2005sp1 dave 1181 [boost.python] can modify enum value dave 1387 Review / update docs to reflect changes dave 1460 Python classes with multiple bases are convertible only to the first class in the lists dave 1482 boost::python::throw_error_already_set should be marked noreturn dave 1516 [python] Failing VC9 regression tests dave 1599 [python] '_set_se_translator': identifier not found dave 1697 [utility][noncopyable] ADL barrier broken by msvc-9.0 dave 1730 No debug libs on Windows by default dave 1744 [getting started] No information on building static libraries with bjam under Windows dave 1851 Issue with proxies and rvalues dave 1860 zip_iterator::value_type should not be reference dave 1887 [doc] input_iterator_archetype is not a valid InputIterator dave 1890 Missing parameters in example code dave 865 Use of C++0x keyword as identifier dave 910 gcc strict-aliasing problems with python dgregor 1009 Improper overflow handling in shortest paths algorithms dgregor 1021 [Graph][reverse_graph] Problem using reverse_graph adapter with an adapted user defined graph dgregor 1076 compile error: disconnecting struct with operator()() doesn't work in VS2005 SP1 dgregor 1164 Floyd Warshall broken with unsigned edge weights dgregor 1192 [boostbook] problem when two files have the same name dgregor 1199 configure doesn't work with path containing whitespaces (MacOS X) dgregor 1310 [result_of] const-qualified function pointer doesn't work dgregor 1326 Unable to check graph isomorphism using LEDA adapter dgregor 1391 dominator_tree_test on Borland/CodeGear outputs overly long line dgregor 1630 gcc-4.3: adjacency_list.hpp includes deprecated header dgregor 375 LEDA graph adaptors do not handle hidden nodes properly dgregor 402 random_vertex/random_edge are unnecessarily inefficient dgregor 403 Document copy_component dgregor 447 reverse_graph and constness of property maps dgregor 556 Bundled graph properties dgregor 708 Dijkstra no_init version should not require VertexListGraph dgregor 732 Johnson All-Pairs needs better "no path" information dgregor 733 Numbered headers don't work with "preferred" syntax dgregor 735 Fruchterman-Reingold grid performance can be improved dgregor 736 Const correctness violation dgregor 738 Memory leaks with signal::connect? dgregor 829 Implicit graph not implement dgregor 852 Problem with Boost and GCC 4.1 djowel 1170 Emit Warnings instead of # symbols in the syntax highlighter djowel 1171 Quickbook title output djowel 1172 non-utf djowel 1176 Space after inline code djowel 1206 Escaping from within code? djowel 1273 CR+LF newlines in position_iterator djowel 1276 spirit problem with _GLIBCXX_DEBUG djowel 1277 Closing section like [pre with } causes Quickbok to crash djowel 1280 sections in imported source files get put inside <para> elements in docbook output djowel 1281 Quickbook produces invalid BoostBook/DocBook XML djowel 1324 tuple should have a swap() that operates element-by-element djowel 1396 wrong result_of invocation around transform_view djowel 1436 [quickbook] inline code inside headings djowel 1484 Quickbook produces illegal docbook for some docinfo fields. djowel 1500 [Spirit/Phoenix] C4512 Compiler warnings from VC8 djowel 1570 Some boost headers aren't ready for gcc 4.3 djowel 1600 duplicate include guard djowel 1601 distane of boost::tuple djowel 1607 Tuple Library Documentation Changes djowel 1610 [MSVC/STLport] [tree/common.hpp] Standard library requirements violation(incomplete type as vector parameter) djowel 1614 vector workaround needed for MSVC9 djowel 1617 spirit gcc-4.3 fix djowel 1619 [Fusion] C4512 warnings from VC9 (Visual Studio 2008) djowel 1651 incorrect typedefs in examples djowel 1763 wrong AST when parser_tag==0 djowel 1764 wrong AST when parser_tag==0 djowel 1844 Quickbook matches forward slashes (for italics) with slashes in links djowel 1864 [Documentation]There is no documentation for repetivive_view djowel 1872 [Spirit2] 'assignment operator could not be generated' warnings from VC9 djowel 1891 quickbook executable receives <dependency> djowel 1892 boost::spirit::static_ causes link error (using wave) djowel 1893 Documentation Corrections to map.html djowel 1894 fusion\support\tag_of.hpp_ boost::fusion::traits dlwalker 613 boost/crc.hpp uses non-standard conforming syntax ebf 1507 [variant] C4512 warnings from VC8.0 ebf 1548 [variant][docs]typo: formal arg_ operand_ should be v in times_two arglist ebf 1654 recursive variants do not handle nested variants correctly. ebf 993 Variant should use least common multiple of alignments_ rather than maximum fcacciola 1666 Visualizer for boost::optional garcia 1581 Boost.MultiArray: Resizing bug if the index is not 0-based garcia 1741 Review schedule out of date gmelquio 1886 Typo in Interval documentation grafik 1041 Cygwin requires PATH setting. grafik 1322 trac rejects patch attachment as spam grafik 1406 Understanding the Tables outdated grafik 1417 Regresson tests hang in Darwin (Tiger) grafik 1430 Regression fails under Cygwin grafik 1433 Trac's spam detection rejects too many valid messages grafik 1512 Broken link to vacpp in bjam docs. grafik 1513 Broken link to bcpp in bjam docs. grafik 1576 cannot read non-ASCII output messages grafik 1577 Some commands don't work because hStdInput == 0 grafik 1663 build.bat cannot set/reset ERRORLEVEL grafik 1733 Website layout overlays on IE7 grafik 1735 [website] Wrong HTML on main documentation page. grafik 1738 Boost Jam details and download link grafik 1739 Search box and Google link grafik 1753 Python docs: bad link to the Jamroot grafik 1771 Statechart TOC mangled. grafik 1776 Documentation page renders incorrectly in Safari 3.1 on OS X grafik 1906 Trac site too hard to find grafik 616 Boost Jam_ and non english directorys grafik 959 linking fails when Boost is compiled with STLport 5.1.* on Linux (names mismatch) grafik 986 Problem building Python modules on boost 1.34.0 hkaiser 1079 boost-1.34.0 fails to compile. concept checks not satisfied. hkaiser 1670 wave almost unusably slow on real-world input igaztanaga 1080 boost::interprocess win32 global file mapping issue igaztanaga 1210 interprocess::barrier hangs during second use under linux (boost 1.33.1) igaztanaga 1390 Interpocess: managed shared memory failing completely under OS X igaztanaga 1634 boost::interprocess::vector cannot contain volatile int igaztanaga 1635 Incomplete include guard in boost/intrusive jano_gaspar 1852 copy constructor does not copy capacity jmaurer 351 Diff in state of mersenne_twister gen between GCC3.41 & CW9 jmaurer 599 uniform_01 copies engine instead of using a reference johnmaddock 1081 Empty string rejected as perl-style regex johnmaddock 1446 POSIX API doesn't use C locale johnmaddock 1451 error: use of C99 long long integer constant johnmaddock 1863 Boost.Regex unstable with Borland Turbo C++ 2006 jsiek 1531 segfault in dynamic_bitset::reference assign operator jsiek 1540 Poisson distribution very slow for large mean (and may also overflow). jsiek 1755 Boost.tokenizer is broken for wide characters - patch attached jsiek 1798 met an error using boost::tokenizer in multi-times in vs2005_ unicode jsiek 1888 Why doesn't InputIterator require that reference is convertible to value_type? jsiek 575 Calling subgraph::global_to_local on a root graph jsiek 636 strange compiling problem for transitive_closure jsiek 815 remove_edge core dumps on self-circle jsiek 875 No iterator based constructor for adjacency_matrix jsiek 900 graphml reader namespace handling is broken kaalus 1184 property_tree assignment (operator) bug kaalus 1604 property_tree xml parser doesn't compile with gcc kaalus 1678 Boost.property_tree::read_xml does not parse UNICODE file with BOMs marshall 1252 [pool] severe overhead with unaligned sizes. marshall 1854 Interval is not available as a component in the SVN system matias 1822 header dependency in boost/serialization/map.hpp nasonov 1220 lexical_cast requires RTTI nasonov 754 boost::any - typeid comparison across shared boundaries nesotto 1629 range/iterator_range.hpp bug nesotto 1675 [range] VC8 - compiler warnings when including range/array headers nesotto 1694 NDEBUG vs. BOOST_ASSERT in iterator_range.hpp nesotto 1748 [ptr_container] compiler warnings from VC9 nesotto 1754 Illegal HTML in range docs. nesotto 1785 assign::list_of works poorly with class constructors nesotto 1795 [ptr_container] minor documentation typo nesotto 1842 boost::sub_rage::front error no-maintainer 1068 Mersenne twister disables streaming for Visual C++ no-maintainer 1222 lambda::ret<T> should declare result_type. no-maintainer 1270 uniform_smallint doesn't compile with lagged_fibonacci random number generators no-maintainer 1515 [lambda] C4512 warnings from VC8.0 no-maintainer 1544 uniform_01 w/ref template param causes ref to ref error no-maintainer 1546 Method boost::random::uniform_int::operator()(engine_ value) is missing no-maintainer 1572 [lambda] smart pointer const-ness affects its contents no-maintainer 1632 Default Interval rounding policies incomplete no-maintainer 1691 [Random] Brokem MSVC workaround no-maintainer 1856 minstd_rand returning different values in 1.35.0 than in 1.34.1 no-maintainer 781 Lambda: (_1 + "y")(string("x")) Doesn't Compile no-maintainer 819 uniform_int<> with type's maximum availaible range error pavol_droba 1152 rle_example fails pavol_droba 1385 begin must be boost-qualified pavol_droba 1761 StringAlgo: Error in an example pavol_droba 1827 String algorithm composite header doesn't include join ramey 1708 Can't serialize class with private destructor ramey 1734 BOOST_STATIC_WARNING can't be passed a dependent expression ramey 1747 [serialization] unreferenced formal parameter warnings from VC9 ramey 1807 boost::archive::xml_archive_exception does not store error code and reports wrong message text ramey 1812 Boost.Serialization fails to build on Cygwin ramey 1823 Archive concept: Incomplete description? ramey 1824 serialization keeps using wchar_t if BOOST_NO_STD_WSTRING is set ramey 1836 bug in serializing wide character strings ramey 1837 Base class missed in binary_wiarchive ramey 1849 Deserialization of std::string overwrites non-copied contents. ramey 1857 IA64_ GCC 4.3_ redefinition of 'struct boost::serialization::implementation_level<std::vector<long int_ std::allocator<long int> > >' ramey 1877 Documentation Corrections - Archive Concepts rogeeff 1383 signal.h features not found on Mac OS rogeeff 1542 [test] compiler errors when building with stdcxx library rogeeff 1644 Boost.Test missing documentation file BOOST_CHECK_CLOSE_FRACTION.html rogeeff 1676 Dead links on Boost.Test example documentation. rogeeff 1723 No subprocess can be started in init_unit_test_suite rogeeff 1746 Online documentation for 1.35.0 is out of date for current lib version rogeeff 1839 Test fails if child process exits with non-zero code rogeeff 1866 Typos in Boost Test documentation rogeeff 1869 Typo in Unit Test Framework documentation samuel_krempp 1699 Compile warning about initialization order. samuel_krempp 1801 Typo in documentation. samuel_krempp 859 boost::format ignores a user defined locale shammah 290 perfomance: memory cleanup for pool takes too long shammah 386 boost::pool_allocator breaks with vector of vectors speedsnail 1138 Problems with TSS and static thread library t_schwinger 1653 wave executable erroneously required for build of function_types lib troyer 1774 serialization: file written with 1.34.1 can't be read in with 1.35 troyer 1778 Possible regression in 1.35 serialization of 2D arrays turkanis 1523 [iostreams] VC8/VC9 compiler warnings turkanis 1545 [boost/rational.hpp] 'noskipws' is not a member of 'std' turkanis 1579 gzip compressor should model DualUseFilter turkanis 1580 Add static assert to prohibit instantiating a chain with mode dual_use turkanis 1649 Fix definition of JavaScript menu to avoid long chains of functions turkanis 1656 Consider implementing flush() for symmetric filters turkanis 1671 type mismatch of buffer size parameter causes overload resolution to fail turkanis 1727 Sample code in documentation does not compile_ has namespace errors. turkanis 1870 zlib_base function names must differ from their zlib counterpart turkanis 1875 Boost.Iostreams warnings with GCC -Wall -W -std=c++98 -pedantic turkanis 1896 boost::iostreams::gzip_decompressor silently ignores multiple members urzuga 574 [boost::lambda] Compile error with libstdc++ debug mode vladimir_prus 1132 program_options documentation error. vladimir_prus 1165 more quoting problems vladimir_prus 1274 Useless error message vladimir_prus 1527 [program_options] Second (and subsequent) lines in tabbed text not aligned correctly vladimir_prus 1530 Program options documentation - Overview - Syntactic Information example typo vladimir_prus 1537 no value given in 'mysql_password =' vladimir_prus 1584 cryptic bbv2 error building quickbook vladimir_prus 1587 [program_options] crashes if value part missing in external configuration file vladimir_prus 1588 [program_options] crashes if value part missing in external configuration file vladimir_prus 1645 Invalid unicode support for default_value vladimir_prus 1679 added 4-way universal binary support from mac osx (ppc_ ppc64_ i386_ x86_64) vladimir_prus 1809 Allow empty values in conf file vladimir_prus 1816 --build-type=complete broken in current svn vladimir_prus 1880 documentation bug vladimir_prus 1904 undefined reference to `boost::program_options::options_description::m_default_line_length' vladimir_prus 469 multitoken broken vladimir_prus 689 [program_options] Endless loop with long default arguments vladimir_prus 850 program_options strips off escaped quotes in some situations witt 583 Fixes for build on IBM pSeries for AIX and Linux witt 834 Homepage regression links witt 957 The "Getting Started" page does not mention the stdlib option witt 973 zip_iterator has value_type == reference -- -- Marshall Marshall Clow Qualcomm, Inc. <mailto:mclow@qualcomm.com> The famous British scientist, Lord Kelvin, said: "When you measure what you are speaking about and express it in numbers, you know something about it, but when you cannot (or do not) measure it, when you cannot (or do not) express it in numbers, then your knowledge is of a meagre and unsatisfactory kind."

1 0

[review] BOOST_SCOPE_EXIT review results
by John Phillips 08 May '08

08 May '08

Here are the review results for the Scope Exit library, submitted by Alexander Nasonov. I would be remiss if I didn't begin these results with an apology and a thank you. The review wizards are sincerely sorry that the result of this review took so long to be presented, and very grateful that Alexander has been so patient and according to a post on the forum has even been working to improve the library in the interim when time allowed. The following people contributed to the review. Kim Barrett, Steven Wantanabe, Oleg Abrosimov, Andrey Semashev, Peder Holt, Johan Nilsson, Maxim Yanchenko, Pavel Vozenilek, Aaron LaFramboise, Ben Kuppers, Goran Mitrovic, Tom Brinkman, Martin Wille, Joseph Gauterin, Matt Gruenke, Dave Abrahams, Christian Holmquist, Mathais Gaunard, Michael Marcin, Daniel Wallin, Zach Laine, Sid Sacek, Wang Yun, and Ilya Sokolov After carefully considering the review comments, I'm pleased to announce that the Scope Exit library is accepted into Boost. As is almost always the case, there are some notes for improvement for this library, and in this case there is even a suggestion for a substantial future restructuring. Let's start with the big one first. As it is currently implemented, SCOPE_EXIT suggests a method for creating a general closure mechanism as a library. This is a useful enough idea that many of the reviewers strongly encouraged Alexander to do it, and provided ideas for implementation details. Alexander should continue to work on this, and when it is ready for review, submit it to Boost. When he gets it accepted into boost, he should consider reworking SCOPE_EXIT to build it on top of the closures and a more traditional scope guard. If this is practical, he should create the new implementation and possibly submit it for a mini-review, since it will be such a big change from the current form. On to the other issues. There were a number of comments on the documentation. Some of the most detailed were in the review by Pavel. Much of the requested information is currently present in the documentation, but not in a format that new readers find intuitive. Along with reorganization, some more examples, some more comparison information, and some actual performance information would be a good idea. Kim would like to see variadic macros supported in the implementation. This is a good idea if a large fraction of currently available compilers support them, but otherwise a low priority. Currently the library requires the user to include type_of headers, even though there is no place in the user code where a type_of appears. This will be confusing for many new users. If possible, look for a way to make the library more self-contained in this regard. Other reviewers requested ways to use the library without any type_of dependence. This would expand the audience for the library, but may not be practical. Consider it and act appropriately. Aaron requested some syntactic sugar for things like if(condition) tests. This may not be a good choice, since it greatly expands the interface while providing only minor simplifications to calls. Consider it and choose. The code needs to check for msvc compilers, since the __LINE__ statement has to be replaced for them. BOOST_SCOPE_EXIT_FASTER_IMPL should be removed. It isn't always faster, and putting experimental features in a release makes no one confident. If it becomes stable, cross-platform and consistently faster, then it can come back. BOOST_SCOPE_EXIT_TRY and BOOST_SCOPE_EXIT_CATCH_ALL are not very useful There is a compile warning because boost_scope_exit_params_struct_nn does not have an assignment operator. Define one and it will go away. Look for ways to make the syntax clearer. Goran pointed out that he doubts code reviews at his job or many others would allow the current syntax. So far, the best suggestion seems to be BOOST_SCOPE_EXIT((cref c) (ref r) (val v)). This also addresses desires to be able to pass by other than references. There was a request for the ability to nest scope_exits and build more complicated structures. I don't see how this could be done in an exception safe manner, so it is probably not a good idea. There was an extended discussion on the use of macros in the public interfaces of Boost libraries. It is certainly true that indiscriminate use of macros is a bad idea, but there is no indication that that is the case for this library. As is always the case for any Boost library, the real question should be "What is the best way to provide the best functionallity?" In this case, no suggestions other than macros have come forth, so macros are the best available choice. My thanks again to everyone who participated, to Alexander for creating and submitting the library and for his patience, and to Jody for organizing the review period. John Phillips Review Wizard

2 1

[thread] Expected behaviour of condition variable wait when the mutex is not locked
by vicente.botet 08 May '08

08 May '08

----- Original Message ----- From: "Anthony Williams" <anthony(a)justsoftwaresolutions.co.uk> To: <threads-devel(a)lists.boost.org> Sent: Monday, April 14, 2008 5:34 PM Subject: Re: [Threads-devel] [boost] Expected behaviour of condition variable wait when unique_lock is not locked > Quoting "vicente.botet" <vicente.botet(a)wanadoo.fr>: > >> which is the expected behaviour of condition variable wait when >> unique_lock is not locked > > Undefined behaviour: a precondition has not been met. IMO this is not satisfactory. At least an exception should be thrown. And the C++0x recomendation states this. "void wait(unique_lock<mutex>& lock); Precondition: lock is locked by the current thread, and either: No other thread is waiting on this condition_variable object, or The lock arguments supplied by all concurrently waiting threads (via wait or timed_wait) return the same value for lock.mutex(). Effects: Atomically calls lock.unlock() and blocks on *this. When unblocked, calls lock.lock() (possibly blocking on the lock) and returns. The function will unblock when this thread is signaled by a call to this->notify_one(), a call to this->notify_all(), or spuriously. If the function exits via an exception, lock.lock() will still be called prior to exiting the function scope. Postconditions: lock is locked by the current thread. Throws: system_error when the effects or postconditions cannot be achieved. " I'm wondering why the condition_variable wait operation do not requires a strict lock (the one introduced by Andrei Alexandrescu in his article about external locking "Multithreading and the C++ Type System") instead of a unique lock or whatever. In this way the interface will force the precondition. Please let me know if this has already been discused in this list. template <typename Lockable> class strict_lock : private boost::noncopyable /*< Is not copyable >*/ { BOOST_CONCEPT_ASSERT((LockableConcept<Lockable>)); public: typedef Lockable lockable_type; explicit strict_lock(lockable_type& obj) : obj_(obj) { obj.lock(); } /*< locks on construction >*/ ~strict_lock() { obj_.unlock(); } /*< unlocks on destruction >*/ typedef bool (strict_lock::*bool_type)() const; /*< safe bool idiom >*/ operator bool_type() const { return &strict_locker::owns_lock; } bool operator!() const { return false; } /*< always owned >*/ bool owns_lock() const { return true; } const lockable_type* mutex() const { return &obj_; } bool is_locking(lockable_type* l) const { return l==mutex(); } /*< strict lockers specific function >*/ /*< no possibility to unlock >*/ private: lockable_type& obj_; strict_lock(); /*< disable default constructor >*/ BOOST_NON_ALIAS(strict_lock); /*< disable aliasing >*/ BOOST_NON_HEAP_ALLOCATED(strict_lock); /*< disable heap allocation >*/ }; namespace boost { class condition_variable // ... void wait(strict_lock<mutex>& l) { # ifndef BOOST_THREAD_CONDITION_VARIABLE_DONT_CHECK_SAME /*< define BOOST_THREAD_CONDITION_VARIABLE_DONT_CHECK_SAME if you don't want to check locker check the same lockable >*/ if (!l.is_locking(&m)) throw lock_error(); /*< run time check throw if not locks the same >*/ # endif // ... do as for unique_lock } }; } Evidently we can have more that one way to implement a strict lock but we have no way to check at compile time that a class is a model of a strict lock, so we need to relai on the "parolle" of the library author and add some optional run time checks. The condition_variable interface can be extended to accept arbitrary locks satisfying some constraints. template <class Locker> void wait(Locker& l) { BOOST_CONCEPT_ASSERT((StrictLockerConcept<Locker>)); BOOST_STATIC_ASSERT((is_strict_lock<Locker>::value)); /*< Locker is a strict lock "sur parolle" >*/ BOOST_STATIC_ASSERT((is_same< Lockable, typename lockable_type<Locker>::type>::value)); /*< that locks the same lockable type >*/ # ifndef BOOST_THREAD_CONDITION_VARIABLE_DONT_CHECK_OWNERSHIP /*< define BOOST_THREAD_CONDITION_VARIABLE_NO_CHECK_OWNERSHIP if you don't want to check locker ownership >*/ if (! l) throw lock_error(); /*< run time check throw if no locked >*/ # endif # ifndef BOOST_THREAD_CONDITION_VARIABLE_DONT_CHECK_SAME /*< define BOOST_THREAD_CONDITION_VARIABLE_DONT_CHECK_SAME if you don't want to check locker check the same lockable >*/ if (!l.is_locking(&m)) throw lock_error(); /*< run time check throw if not locks the same >*/ # endif // ... do as for unique_lock } is_strict_lock must be specialized by the strict locker implementer to state "sur parolle" that the class is a strict lock. Any comments? ____________________ Vicente Juan Botet Escriba

5 17

[interprocess] non-ASCII characters in headers
by Daniel James 08 May '08

08 May '08

Hi Ion, There are a few non-ASCII characters is the interprocess headers, which cause Boostbook to reject a few of the XML files and miss a few pages from the reference documentation (such as the flat_map documentation). I've fixed them in my doc branch. Is it okay for me to merge it into trunk? http://svn.boost.org/trac/boost/changeset/45154 thanks, Daniel

3 2

Why does boost::thread::thread_start_function have catch(...)? (Win32)
by James Talbut 08 May '08

08 May '08

By calling std::terminate in the catch handler we lose the JIT debugger - and thus information about what the exception is that we haven't caught. Without the catch the process is still going to be killed, so what's the benefit of having that? Thanks. Jim P Consider the environment. Please don't print this email. ________________________________________________________________________ This e-mail, and any attachment, is confidential. If you have received it in error, do not use or disclose the information in any way, notify me immediately, and please delete it from your system. ________________________________________________________________________

3 6

Re: [boost] [interprocess] non-ASCII characters in headers
by Daniel James 08 May '08

08 May '08

On 07/05/2008, Marshall Clow <marshall(a)idio.com> wrote: > > My opinion is that all of those changes are fine - > except for the one where you changed "Dietmar Kühl"'s name. I assumed it would be okay because it's spelt that way in other places: http://www.boost.org/users/people/dietmar_kuehl.html http://svn.boost.org/trac/boost/browser/trunk/boost/filesystem/operations.h… I think that the other ways to get this to work would be: to use UTF-8 in the source file, get Doxygen to output UTF-8, or get it to markup the encoding in its output. Daniel

2 1

[thread] Documentaion and implementation incoherences
by vicente.botet 08 May '08

08 May '08

Hi, Only some comments and questions. * mutex native_handle_type and native_handle() are missing in the doc Should these be defined for timed_mutex, recursive_mutex, ...? * The documentation do not includes a rationale. Could you adapt the rationale from Howard E. Hinnant Mutex, Lock, Condition Variable Rationale http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2406.html#Introduc…, or at least add reference to this document in the rationale? Best ____________________ Vicente Juan Botet Escriba

2 2

[thread] thread_group differences between pthread and windows
by vicente.botet 08 May '08

08 May '08

Hi, Is there any hiden raison explaining the declarations and implementation of thread_group are different for pthread and windons? If not why not to put it in a separate file? Best _____________________ Vicente Juan Botet Escriba

2 1

[constrained_value] ignore_policy, overhead?
by Neal Becker 07 May '08

07 May '08

I'm wondering if I can selectively switch off bounds checking without overhead? I added: /** Error policy for constrained that ignores bounds. */ struct ignore { /// The policy invocation operator. /// If @a nv is below the range, assigns @c c.lower_bound() to @a ov. /// If @a nv is above the range, assigns @c c.upper_bound() to @a ov. /// Otherwise fires an assertion. /// @remarks @a V must be @c Assignable from @a L::result_type and @a U::result_type. template <typename V, class L, class U, class C> void operator () (V & ov, const V & nv, const within_bounds < L, value_generator::integral<bool, true>, U, value_generator::integral<bool, true>, C> & c) const { } }; I'm wondering if the this will eliminate all overhead allowing the speed of the underlying ValueType (e.g., int)?

2 1