Re: [Boost-bugs] [Boost C++ Libraries] #11756: boost.Test: non standards compliant use of FE_* macros (unable to compile boost test library on FPU-less arches)

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #11756: boost.Test: non standards compliant use of FE_* macros (unable to compile boost test library on FPU-less arches)
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2017-02-27 08:29:34

#11756: boost.Test: non standards compliant use of FE_* macros (unable to compile
boost test library on FPU-less arches)
----------------------------------+------------------------
  Reporter:  bartosz.krasinski@…  |      Owner:  renficiaud
      Type:  Patches              |     Status:  reopened
 Milestone:  Boost 1.64.0         |  Component:  test
   Version:  Boost 1.59.0         |   Severity:  Problem
Resolution:                       |   Keywords:
----------------------------------+------------------------

Comment (by renficiaud):

 Hi there again,

 I moved the FPE logic in the macro
 ```BOOST_TEST_FPE_SUPPORT_WITHOUT_SEH__``` . It would be cool if you can
 test the branch again.

 The way I see this is that there is only 3 options in the code that should
 be handled:

 * no fpe
 * seh based fpe
 * implementation based on fenv (and in that case, not all platforms
 support all signals)

 All in all, I think that moving this switch to 2 configuration macros make
 the code easier to understand and to maintain.

 Let me know the result of your tests. 1.64 will be closing soon, it would
 be good to have your feedback asap :)

 Thanks,
 Raffi

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/11756#comment:37>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.