|
Geometry : |
Subject: [ggl] Polygon DP simplification
From: Mateusz Loskot (mateusz)
Date: 2011-09-30 06:39:06
On 30/09/11 11:32, Bruno Lalande wrote:
> I don't remember about the details but I'm pretty sure this sqrt was
> absent on purpose. It was pulled away from the actual calculation to
> avoid useless square root computations when comparing distances, and it
> is the responsibility of the caller to call sqrt.
Bruno,
Yes, it makes perfect sense to me.
> So probably one of the
> algorithms/operations used fails to do it, we will have to identify
> which one. I assume adding the sqrt within pythagoras itself causes all
> the operations that use it properly to fail unit tests.
Indeed, that's why I didn't decide to commit it. The patch is fragile.
> I guess Barend will have more details about the actual implementation.
Yes.
Best regards,
-- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org Member of ACCU, http://accu.org
Geometry list run by mateusz at loskot.net