Re: [jamboost] symmetric/optional features

From: Vladimir Prus (ghost_at_[hidden])
Date: 2002-07-05 10:22:11

David Abrahams wrote:
> From: "Vladimir Prus" <ghost_at_[hidden]>
>
> > David Abrahams wrote:
> > > Fixed.
> >
> > Thank you. I've just made this new rule work together with the rest of
>
> the
>
> > code, so that non-optional non-free features are added to the build
>
> request.
>
> > I had to add "build-request.expand-with-defaults" rule, as otherwise that
> > functionality would be present in two different places.
>
> I think the right thing is to just fold all that functionality into
> "expand". I was just reluctant to re-write all those tests which do the
> expansion without the defaults, because I think they're valuable for the
> purposes of checking that the implementation is working. 

I understand you.

> Maybe you can help resolve this tension somehow...

Can't we just rename current 'expand' to something else and current 
'expand-with-default' to 'expand'. This way you won't have to rewrite any 
tests.

- Volodya